nanoexpress / middlewares

Middleware packages for nanoexpress
20 stars 10 forks source link

@nanoexpress/middleware-schemator Possibility to add title to initialize options #31

Open torbjorn-kvist opened 3 years ago

torbjorn-kvist commented 3 years ago

Feature Request

Is you/your team sponsoring this project

If your team sponsoring this project, please attach here your team lead or who purchased license GitHub login

Is your feature request related to a problem? Please describe

Currently there is no way to set a title from the Initialize options app.get('/swagger', render({ exposePath:/${exposePath}}));

But possible if you call schematorInstance.render(options) directly. So one way is probably to just define the app.get('swagger', func) to override the path.

Describe the solution you'd like

Add an option to Initialize options e.g options.swaggerUITitle or similar.

Willing to create a PR for the change! Just wanted to check if this is something that are inline in what the middleware should do.

Describe alternatives you've considered

Expose it in some other way or just override app.get('swagger', func)?

Teachability, Documentation, Adoption, Migration Strategy

dalisoft commented 3 years ago

@torbjorn-kvist I happy to see your PR and we'll merge if it's correctly implemented and does not break old logic

game5413 commented 3 years ago

I already tried to develop that feature and it working, maybe later will make a PR for this request.