search

nanogiants / twineCSV

Converts your twine formatted files to csv and vice versa
MIT License
7 stars 2 forks source link

Dependency to rubyXL #5

Closed DTown closed 5 years ago

DTown commented 5 years ago

Version 1.1.0 Maybe you should mention the dependency to rubyXL

Getting:

/usr/local/lib/ruby/gems/2.4.0/gems/commander-4.4.3/lib/commander/runner.rb:409:in `block in require_program': program version required (Commander::Runner::CommandError)
    from /usr/local/lib/ruby/gems/2.4.0/gems/commander-4.4.3/lib/commander/runner.rb:408:in `each'
    from /usr/local/lib/ruby/gems/2.4.0/gems/commander-4.4.3/lib/commander/runner.rb:408:in `require_program'
    from /usr/local/lib/ruby/gems/2.4.0/gems/commander-4.4.3/lib/commander/runner.rb:52:in `run!'
    from /usr/local/lib/ruby/gems/2.4.0/gems/commander-4.4.3/lib/commander/delegates.rb:15:in `run!'
    from /usr/local/lib/ruby/gems/2.4.0/gems/commander-4.4.3/lib/commander/import.rb:5:in `block in <top (required)>'
/usr/local/Cellar/ruby/2.4.0/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- rubyXL (LoadError)
    from /usr/local/Cellar/ruby/2.4.0/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
    from /usr/local/lib/ruby/gems/2.4.0/gems/twineCSV-1.1.0/lib/twineCSV.rb:3:in `<top (required)>'
    from /usr/local/lib/ruby/gems/2.4.0/gems/twineCSV-1.1.0/bin/twineCSV:4:in `require_relative'
    from /usr/local/lib/ruby/gems/2.4.0/gems/twineCSV-1.1.0/bin/twineCSV:4:in `<top (required)>'
    from /usr/local/bin/twineCSV:22:in `load'
    from /usr/local/bin/twineCSV:22:in `<main>'

This helped: gem install rubyXL

dasheck0 commented 5 years ago

Thanks for the heads. Installing peer dependencies on your own is no good practise. I will add rubyXL as dependency to twineCSV. This way it will be installed along.

dasheck0 commented 5 years ago

I added rubyXL as runtime dependency. It is available with version 1.1.2. See: https://rubygems.org/gems/twineCSV/versions/1.1.2