nanograv / PINT

PINT is not TEMPO3 -- Software for high-precision pulsar timing
Other
118 stars 101 forks source link

CI failing after recent merge #1835

Open dlakaplan opened 1 week ago

dlakaplan commented 1 week ago

After #1798 was merged, now getting CI failures only for py312-test-cov:

__________________ ERROR collecting tests/test_toa_shuffle.py __________________
/home/runner/work/PINT/PINT/tests/test_toa_shuffle.py:22: in <module>
    class TOAOrderSetup:
/home/runner/work/PINT/PINT/tests/test_toa_shuffle.py:27: in TOAOrderSetup
    simulation.make_fake_toas_uniform(
/home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/simulation.py:327: in make_fake_toas_uniform
    ts = pint.toa.get_TOAs_array(
/home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/toa.py:3002: in get_TOAs_array
    t.apply_clock_corrections(
/home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/toa.py:2230: in apply_clock_corrections
    clock_corrections = site.clock_corrections(
/home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/observatory/topo_obs.py:331: in clock_corrections
    corr = super().clock_corrections(
/home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/observatory/__init__.py:436: in clock_corrections
    corr += self.gps_correction(t, limits=limits)
/home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/observatory/__init__.py:249: in gps_correction
    _load_gps_clock()
/home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/observatory/__init__.py:123: in _load_gps_clock
    _gps_clock = find_clock_file(
/home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/observatory/__init__.py:965: in find_clock_file
    global_clock = GlobalClockFile(
/home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/observatory/clock_file.py:823: in __init__
    self.hash = compute_hash(f)
/home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/utils.py:2665: in compute_hash
    with open_or_use(filename, "rb") as f:
/opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/contextlib.py:137: in __enter__
    return next(self.gen)
/home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/utils.py:504: in open_or_use
    with open(f, mode) as fl:
E   FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/.astropy/cache/download/url/d3c81b5766f4bfb84e65504c8a453085/contents'

The CI for the PR passed, but this has now failed multiple times. Any ideas @abhisrkckl ?

abhisrkckl commented 1 week ago

This is the same test that was creating problem for macos. I had to run it serially in macos to get in to work. But the Ubuntu tests were fine before merging.

I think there may be a deeper issue with that test. I think the best option is to revert the merge now and fix it.

On Wed, 4 Sept, 2024, 9:54 pm David Kaplan, @.***> wrote:

After #1798 https://github.com/nanograv/PINT/pull/1798 was merged, now getting CI failures only for py312-test-cov:

__ ERROR collecting tests/test_toa_shuffle.py __ /home/runner/work/PINT/PINT/tests/test_toa_shuffle.py:22: in class TOAOrderSetup: /home/runner/work/PINT/PINT/tests/test_toa_shuffle.py:27: in TOAOrderSetup simulation.make_fake_toas_uniform( /home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/simulation.py:327: in make_fake_toas_uniform ts = pint.toa.get_TOAs_array( /home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/toa.py:3002: in get_TOAs_array t.apply_clock_corrections( /home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/toa.py:2230: in apply_clock_corrections clock_corrections = site.clock_corrections( /home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/observatory/topo_obs.py:331: in clock_corrections corr = super().clock_corrections( /home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/observatory/init.py:436: in clock_corrections corr += self.gps_correction(t, limits=limits) /home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/observatory/init.py:249: in gps_correction _load_gps_clock() /home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/observatory/init.py:123: in _load_gps_clock _gps_clock = find_clock_file( /home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/observatory/init.py:965: in find_clock_file global_clock = GlobalClockFile( /home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/observatory/clock_file.py:823: in init self.hash = compute_hash(f) /home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/utils.py:2665: in compute_hash with open_or_use(filename, "rb") as f: /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/contextlib.py:137: in enter return next(self.gen) /home/runner/work/PINT/PINT/.tox/py312-test-cov/lib/python3.12/site-packages/pint/utils.py:504: in open_or_use with open(f, mode) as fl: E FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/.astropy/cache/download/url/d3c81b5766f4bfb84e65504c8a453085/contents'

The CI for the PR passed, but this has now failed multiple times. Any ideas @abhisrkckl https://github.com/abhisrkckl ?

— Reply to this email directly, view it on GitHub https://github.com/nanograv/PINT/issues/1835, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE6CGNZMVKISLROAQOJ33ULZU5QQNAVCNFSM6AAAAABNVAX6JCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYDMMJWGE3TGNY . You are receiving this because you were mentioned.Message ID: @.***>

dlakaplan commented 1 week ago

So I make a PR to revert the merge, but I thought that test_toa_selection was failing before (and it has a separate entry in tox.ini) while it's test_toa_shuffle here.

But both are probably due to cache issues.