search

nanograv / PINT

PINT is not TEMPO3 -- Software for high-precision pulsar timing
Other
121 stars 101 forks source link

Phases calculation using the Designmatrix feature #1850

Closed devbhakt closed 1 week ago

devbhakt commented 1 month ago

This adds in a calculation that using the designmatrix to calculate the phases of each photon during each step of the MCMC run in event_optimize. This leads to a dramatic speed up in the MCMC run.

Here are some test runs I have done with real gamma-ray data. The samples line up well with the exception of the internal PHASE parameter that is written into the fitter within event_optimize. This parameter is an internal parameter that serves as analogous to absolute phase and does not effect the timing model. J1231_compare_samps_triangle J2028_compare_samps_triangle

abhisrkckl commented 1 month ago

Please add a CHANGELOG entry

abhisrkckl commented 3 weeks ago

Shall I merge this? The changes look OK to me.