search

nanograv / PINT

PINT is not TEMPO3 -- Software for high-precision pulsar timing
Other
122 stars 101 forks source link

model.get_barycentric_toas() should return Time() object #679

Open paulray opened 4 years ago

paulray commented 4 years ago

Right now model.get_barycentric_toas() returns an astropy Quantity with units of days. I think it might be preferable to have it return a Time() object with scale="tdb". For one thing, I tried to use format_toa_line() to write out those barycentric times but it caused an exception. I think very few places use this function so far, so I think it should not be too big a deal to change. Also, this would keep the timescale along with the MJD value.

paulray commented 4 years ago

At telecon we decided to change to get_barycentric_times() and return Time() object