Remove soft replacement for missing sksparse

nanograv / enterprise

ENTERPRISE (Enhanced Numerical Toolbox Enabling a Robust PulsaR Inference SuitE) is a pulsar timing analysis code, aimed at noise analysis, gravitational-wave searches, and timing model analysis.

https://enterprise.readthedocs.io

MIT License

65 stars 67 forks source link

Remove soft replacement for missing sksparse #258

Closed jellis18 closed 3 years ago

jellis18 commented 3 years ago

In two places there are try-except statements that try to import sksparse and replace it with scipy otherwise. This prints or logs a message but I think we should get rid of this and require sksparse.

Especially after #257 is merged and scikit-sparse becomes an official dependency

vallis commented 3 years ago

I support requiring sksparse and not defaulting to scipy: it's too confusing to support sparse cholesky through different libraries. Please go ahead with a PR if you have the code ready.

jellis18 commented 3 years ago

@vallis I'll get to this soon. I was off last week, hence the burst of activity but now it may have to wait til the weekend.

vallis commented 3 years ago

Solved by @jellis18 with #260