search

nanograv / enterprise

ENTERPRISE (Enhanced Numerical Toolbox Enabling a Robust PulsaR Inference SuitE) is a pulsar timing analysis code, aimed at noise analysis, gravitational-wave searches, and timing model analysis.
https://enterprise.readthedocs.io
MIT License
64 stars 65 forks source link

Fix sksparse convention bug in utils.ConditionalGP #316

Closed vallis closed 2 years ago

vallis commented 2 years ago

The scikit-sparse.cholmod returns the LL^T factorization of a matrix modulo a permutation P. This is now applied correctly in computing conditional posterior draws.

codecov[bot] commented 2 years ago

Codecov Report

Merging #316 (694618a) into master (124b788) will decrease coverage by 0.02%. The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
- Coverage   88.00%   87.97%   -0.03%     
==========================================
  Files          13       13              
  Lines        2977     2978       +1     
==========================================
  Hits         2620     2620              
- Misses        357      358       +1
Impacted Files Coverage Δ
enterprise/signals/utils.py 86.45% <87.50%> (-0.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 124b788...694618a. Read the comment docs.