nanograv / enterprise

ENTERPRISE (Enhanced Numerical Toolbox Enabling a Robust PulsaR Inference SuitE) is a pulsar timing analysis code, aimed at noise analysis, gravitational-wave searches, and timing model analysis.
https://enterprise.readthedocs.io
MIT License
64 stars 65 forks source link

Upgrading black to 22.3.0, editing code accordingly #318

Closed vallis closed 2 years ago

vallis commented 2 years ago

CI fails otherwise because black is incompatible with package click. The new black wants to make a few style changes, but they all seem reasonable or positive.

codecov[bot] commented 2 years ago

Codecov Report

Merging #318 (46df56f) into master (2df96c2) will increase coverage by 0.10%. The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   87.94%   88.05%   +0.10%     
==========================================
  Files          13       13              
  Lines        2978     2980       +2     
==========================================
+ Hits         2619     2624       +5     
+ Misses        359      356       -3     
Impacted Files Coverage Δ
enterprise/signals/signal_base.py 90.11% <33.33%> (-0.11%) :arrow_down:
enterprise/signals/gp_priors.py 89.23% <80.00%> (ø)
enterprise/signals/utils.py 86.45% <83.33%> (ø)
enterprise/constants.py 100.00% <100.00%> (ø)
enterprise/signals/gp_bases.py 86.66% <100.00%> (ø)
enterprise/signals/gp_signals.py 90.30% <100.00%> (ø)
enterprise/signals/parameter.py 80.24% <100.00%> (+1.61%) :arrow_up:
enterprise/signals/white_signals.py 98.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2df96c2...46df56f. Read the comment docs.

vallis commented 2 years ago

Hmm... it seems the python-3.6 test failure is due to PINT. Will watch for a resolution there, or we could just drop 3.6.

vallis commented 2 years ago

Dropping Python 3.6 to sidestep a PINT bug. 3.6 is EOLed and deprecated anyway.