search

nanograv / enterprise

ENTERPRISE (Enhanced Numerical Toolbox Enabling a Robust PulsaR Inference SuitE) is a pulsar timing analysis code, aimed at noise analysis, gravitational-wave searches, and timing model analysis.
https://enterprise.readthedocs.io
MIT License
64 stars 65 forks source link

PINTPulsar does not check for coordinate units #363

Open NihanPol opened 10 months ago

NihanPol commented 10 months ago

I am trying to read in non-nanograv and non-PTA data, where the position of the pulsar is given in equatorial coordinates (as opposed to ecliptic coordinates used in nanograv), where RA is in units of hhmmss.

Then enterprise pulsar object does not check for units, assuming they are supplied in radians, which results in an incorrect position used for these pulsars.

scottransom commented 10 months ago

facepalm

vallis commented 10 months ago

Is this a PINT issue or enterprise? If PINT has these as astropy Quantity values with units, can you propose code to fix the problem?

vhaasteren commented 9 months ago

This is fixed by #370.

However, note that we do need to pay more attention to units between tempo2 and PINT in general. The units of the designmatrix are not compatible yet either