nanograv / enterprise

ENTERPRISE (Enhanced Numerical Toolbox Enabling a Robust PulsaR Inference SuitE) is a pulsar timing analysis code, aimed at noise analysis, gravitational-wave searches, and timing model analysis.
https://enterprise.readthedocs.io
MIT License
64 stars 65 forks source link

Units not consistent across packages #369

Closed vhaasteren closed 9 months ago

vhaasteren commented 9 months ago

Tempo2 and Enterprise do not keep track of units internally, whereas PINT does.

The PintPulsar object converts PINT quantities without properly regarding units. Resulting inconsistencies include:

Tempo2 units of the design matrix are not straightforward to determine in general. Ideally we would fix this in conjunction with libstempo units support.

Non-linear timing model analysis and projects depending on position are affected.

vhaasteren commented 9 months ago

Duplicate of #363