search

nanograv / enterprise

ENTERPRISE (Enhanced Numerical Toolbox Enabling a Robust PulsaR Inference SuitE) is a pulsar timing analysis code, aimed at noise analysis, gravitational-wave searches, and timing model analysis.
https://enterprise.readthedocs.io
MIT License
67 stars 67 forks source link

fix missing cholmod.h #378

Closed AaronDJohnson closed 8 months ago

AaronDJohnson commented 8 months ago

At the moment, suitesparse has a very odd default installation location after the previous changes to the install.

I think this actually should break on both linux AND mac, but apt and conda have suitesparse version 5.10.1 instead of 7.6.0 which can be found in brew.

Running CI to see if things are working now with the updated version

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.37%. Comparing base (c49646c) to head (ec94ac8).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/nanograv/enterprise/pull/378/graphs/tree.svg?width=650&height=150&src=pr&token=7Sjk8cLA85&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nanograv)](https://app.codecov.io/gh/nanograv/enterprise/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nanograv) ```diff @@ Coverage Diff @@ ## master #378 +/- ## ======================================= Coverage 88.37% 88.37% ======================================= Files 13 13 Lines 3012 3012 ======================================= Hits 2662 2662 Misses 350 350 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/nanograv/enterprise/pull/378?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nanograv). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nanograv) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/nanograv/enterprise/pull/378?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nanograv). Last update [c49646c...ec94ac8](https://app.codecov.io/gh/nanograv/enterprise/pull/378?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nanograv). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nanograv).
AaronDJohnson commented 8 months ago

Even if these pass, I have removed the Linux tests, so wait to merge until I add them back in, please.

AaronDJohnson commented 8 months ago

At least they're all installing now. I'm going to make a final commit to allow the Linux tests to run.

AaronDJohnson commented 8 months ago

@vhaasteren should I merge this into main now?

AaronDJohnson commented 8 months ago

@vhaasteren Oops -- I merged this just before reading the rest of your comment... (I had read it previously, but my phone only showed the "looks good" part of it). I thought since this was a bug that would affect any pull request, it should go into master. Is that not the case here? It doesn't affect the code in the project at all.

vhaasteren commented 8 months ago

Yes, master is fine also. Just merge it back into dev then 👍