search

nanograv / enterprise_extensions

A set of extension codes, utilities, and scripts for the enterprise PTA analysis framework.
MIT License
27 stars 60 forks source link

MDC1 fix #208

Open astrolamb opened 1 year ago

astrolamb commented 1 year ago

@Hazboun6 @AaronDJohnson @stevertaylor fixes model_general to use MDC1 - set flag mdc1=True

astrolamb commented 1 year ago

@AaronDJohnson do you have a suggestion on how to fix these dependency errors?

AaronDJohnson commented 1 year ago

I'm not sure what is going on here. It looks like sksparse is failing to install, but nothing about it has changed since 2022.

AaronDJohnson commented 1 year ago

Okay. It's a problem with sksparse, but it's because Cython was updated yesterday. This needs to be fixed, but I may not have time to do it myself within the next week. A temporary fix could be to pin Cython to versions <3.0, but long term we don't want to do this.

AaronDJohnson commented 1 year ago

@astrolamb I've merged a temporary fix to scikit-sparse to constrain the Cython version to <3.0. I'll restart the tests in a couple of hours.

astrolamb commented 1 year ago

Awesome, thanks @AaronDJohnson for finding this!

AaronDJohnson commented 1 year ago

Now the issue is with libstempo. Basically, the changes to Cython have broken most Cython packages. I've submitted a PR to libstempo to limit the Cython version.