search

nanograv / enterprise_extensions

A set of extension codes, utilities, and scripts for the enterprise PTA analysis framework.
MIT License
27 stars 60 forks source link

Adding Gibbs sampling code to ENTERPRISE EXTENSIONS #230

Closed NimaLaal closed 6 months ago

NimaLaal commented 6 months ago

The updated Gibbs sampling code is added alongside its test. This method performs the Gibbs sampling of single-pulsar analyses.

NimaLaal commented 6 months ago

Do I need to use "black" for the linting issues?

vhaasteren commented 6 months ago

Do I need to use "black" for the linting issues?

Yes, black should fix the linting

vhaasteren commented 6 months ago

Looking at the code, it seems you've included more than just the Gibbs sampler. As fas as I can see, this PR should only included gibbs.py and test_gibbs.py, is that right?

 enterprise_extensions/altpol/altmodel.py               | 137 ++++++++++++++++++++++++++++++
 enterprise_extensions/altpol/altorfs.py                |  45 ++++++++++
 enterprise_extensions/altpol/altutils.py               | 232 +++++++++++++++++++++++++++++++++++++++++++++++++++
 enterprise_extensions/blocks.py                        |   5 +-
 enterprise_extensions/frequentist/optimal_statistic.py |  30 ++++---
 enterprise_extensions/gibbs_sampling/gibbs.py          | 468 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/test_gibbs.py                                    |  55 ++++++++++++

Could you split off the alternative polarization utilities and blocks updates in a different branch? If you work on multiple features, it's often more maintainable to develop them in separate git branches, and then file a PR from one of those into the main repo. Then you can keep stuff that isn't ready out of the PR