nanograv / holodeck

Massive Black-Hole Binary Population Synthesis for Gravitational Wave Calculations ≋●≋●≋
https://holodeck-gw.readthedocs.io
MIT License
31 stars 11 forks source link

notebooks\devs\toy-strain-model.ipynb #113

Open Florent566 opened 3 months ago

Florent566 commented 3 months ago

In the notebooks\devs\toy-strain-model.ipynb, "import holodeck.evolution" and "import holodeck.population" weren't working, so I replaced them with "import holodeck.discrete.evolution" and "import holodeck.discrete.population". Maybe the directory was changed? "import zcode.math" is also not working, but I don't know what to change it by.

lzkelley commented 3 months ago

Thanks for pointing this out. This notebook is very old and almost completely deprecated. (Much of the materials in the notebooks/devs subfolder are deprecated/defuct in some way.) That being said: the two zmath methods that are being used are (1) random_power (which can also be found in holodeck.utils), and (2) spacing -- and this one can be replaced by np.logspace(*np.log10(masses), NBINS+1). Let me know if there are particular components from this notebook that would be helpful for you!

Florent566 commented 3 months ago

Okay thank you! No worries, I was just wondering.