BUG? check if illustris masses are properly ordered 1th should be secondary, 0th should primary

nanograv / holodeck

Massive Black-Hole Binary Population Synthesis for Gravitational Wave Calculations ≋●≋●≋

https://holodeck-gw.readthedocs.io

MIT License

34 stars 11 forks source link

Open lzkelley opened 1 year ago

mssiwek commented 1 year ago

A few functions to look out for, where primary and secondary masses may not be identified correctly:

_dadt_dedt() in Sesana_Scattering (however, this will be fixed when merging dev with cbd_torques)
_attenuation_BBR1980
_dadt_dedt() in Dynamical_Friction_NFW(). Check the below lines of code:
---- Get effective mass of inspiraling secondary
```
m2 = mass[:, 1]
mstar_sec = self._mmbulge.mstar_from_mbh(m2, scatter=False)
```