nanograv / pint_pal

A long-lived repository for NANOGrav Pulsar Timing workflows and analysis.
MIT License
6 stars 17 forks source link

Fix path handling in notebook runner to allow use with IPTA DR3 #28

Closed rossjjennings closed 1 year ago

rossjjennings commented 1 year ago

This makes the path handling in the notebook runner a bit more flexible, in a way that should make it possible to do notebook autoruns for IPTA DR3 and other future datasets where we use pint_pal as a standalone package. None of the changes should affect the way we had been doing notebook autoruns for the NANOGrav 15-year dataset.

Specifically, the changes are:

rossjjennings commented 1 year ago

The test failure doesn't seem to be related to this PR specifically. It looks like it's failing to download some packages related to Ghostscript.

rossjjennings commented 1 year ago

OK, I think I fixed the previous failure, which was related to a missing "apt-get update" in GitHub Actions. The new failure is legitimately a problem with my changes.

rossjjennings commented 1 year ago

It turned out I had to change the par-directory and tim-directory specified in PINT Pal's test config files. These were "wrong" before this change, too, but previously it didn't matter because they were overridden by run_notebook() anyway.

swiggumj commented 1 year ago

Thanks for taking care of this Ross, and for having a look, Joe.