nanograv / pint_pal

A long-lived repository for NANOGrav Pulsar Timing workflows and analysis.
MIT License
6 stars 17 forks source link

Change EquadNoise to MeasurementNoise #52

Closed AaronDJohnson closed 10 months ago

AaronDJohnson commented 10 months ago

See #51

This updates to the new EQUAD definitions in the outlier analysis to avoid the errors that are associated with the old convention of EQUAD. I have assumed T2EQUAD is the preferred convention.

AaronDJohnson commented 10 months ago

If someone could run a test with this fix (it's a couple of lines of code) and make sure that this convention is correct and that things do indeed run with the updated version of enterprise, that would be ideal. I do not have any experience with running this outlier analysis.

msthomps commented 10 months ago

Hello, with this fix I successfully ran an excision without error! Here are the final few lines it provided:

INFO: Selecting 2165 TOAs out of 2552 (387 removed based on resumption after write_tim (excise)). [pint_pal.utils] INFO: Specified TOA excision keys: set() [pint_pal.timingconfiguration] INFO: Selecting 2165 TOAs out of 2552 (0 more removed based on manual cuts, specified keys). [pint_pal.utils] INFO: Specified TOA excision keys: set() [pint_pal.timingconfiguration] INFO: Selecting 2165 TOAs out of 2552 (0 more removed based on manual cuts, specified keys). [pint_pal.utils] INFO: Specified TOA excision keys: set() [pint_pal.timingconfiguration] INFO: Selecting 2165 TOAs out of 2552 (0 more removed based on manual cuts, specified keys). [pint_pal.utils] INFO: Proposed DMX model OK. [pint_pal.dmx_utils] INFO: Proposed DMX ranges are the same as input; keeping input DMX model. [pint_pal.dmx_utils] INFO: Selecting 2165 TOAs out of 2552 (387 removed based on resumption after highlighting cuts). [pint_pal.utils]

Is there anything specific I should check?