search

nanograv / pint_pal

A long-lived repository for NANOGrav Pulsar Timing workflows and analysis.
MIT License
6 stars 19 forks source link

Large Residuals feature proposal: Find Potential Bad Jump Flags #66

Closed JamisonTalley closed 3 months ago

JamisonTalley commented 4 months ago

Adds an option to large_residuals() that can print a list of potential Jump flags that only appear in the toas with large residuals, alongside the percent of such toas that share that flag. The goal of this feature is to make troubleshooting combinations easier. This PR also includes a change to the print_bad implementation that checks the print_bad boolean before finding toa names.

rossjjennings commented 4 months ago

The current test failure seems to be about a change introduced in PINT 1.0.1. I've opened issue #67 about it.

rossjjennings commented 3 months ago

Now that Michael's fix for #67 is merged, you should try merging the fix into this branch, and see if that makes the tests pass.

rossjjennings commented 3 months ago

As discussed at the git-flowers meeting yesterday, merging this will also merge the changes from #68 into master. But doing so appears to be desireable in any case.

rossjjennings commented 3 months ago

I'm going to go ahead and merge this now.