search

nanohop / sketch-to-react-native

Convert Sketch files into React Native components
MIT License
2.33k stars 166 forks source link

Test multiple sketch files #17

Open chrisachard opened 7 years ago

chrisachard commented 7 years ago

There is a great set of sketch files here: https://www.invisionapp.com/do

Download and test them, and report any errors as issues.

chrisachard commented 7 years ago

Also, if you have any other good React Native Sketch templates resources, leave a comment here with a link!

Rob-Rychs commented 7 years ago

Started working on this issue.

Rob-Rychs commented 7 years ago

That do-sketch library has 130 exportable svgs so I created a separate repo to start testing them, here are the first 13 (or row 1) of svgs with their errors listed in readme, svgs in images folder and generated output files/folders in respective component folders https://github.com/Rob-Rychs/do-sketch-to-react-native-test

chrisachard commented 7 years ago

This is awesome. Thanks!

On Thu, Oct 26, 2017 at 6:02 AM, Rob-Rychs notifications@github.com wrote:

That do-sketch library has 130 exportable svgs so I created a separate repo to start testing them, here are the first 13 (or row 1) of svgs with their errors listed in readme, svgs in images folder and generated output files/folders in respective component folders https://github.com/Rob-Rychs/do-sketch-to-react-native-test

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nanohop/sketch-to-react-native/issues/17#issuecomment-339616788, or mute the thread https://github.com/notifications/unsubscribe-auth/AACIncBJgh9J1EBiN4qjO4btYK6Q5KkYks5swFjQgaJpZM4QBGW5 .

horacioh commented 7 years ago

I test one of my files & it was not a good result. you can see the result here: https://snack.expo.io/HkyvLL0CW here is all the files related to my test (sketch file, output): https://www.dropbox.com/s/2friwhozpgn9v7c/sketch-to-react-native_test.tar.gz?dl=0

is there anything I can do to help let me know!

chrisachard commented 7 years ago

Sorry it didn't work well for you. Uploading your sketch file was great, thanks! That is the most helpful thing we can have - examples. We're working on the next version, which should fix some of the problems you're seeing... Once we get the sketch plugin (for better asset exports), and the new neural net (that can detect buttons, etc), the output should be much improved.

horacioh commented 7 years ago

hey its fine! this is a really awesome project I was curious to test.

THANK YOU to open source it! 🙏🏻🙏🏻👏🏻👏🏻👏🏻