search

nanomsg / nng

nanomsg-next-generation -- light-weight brokerless messaging
https://nng.nanomsg.org
MIT License
3.78k stars 485 forks source link

fixes #1543 Deadlock in nng_close(socket) #1786

Closed gdamore closed 7 months ago

gdamore commented 7 months ago

This looks like a possible problem that may be windows specific involving the flow for IO completion ports. This simplifies the logic a little bit, and should ensure that canceled requests on pipes do not restart.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.13%. Comparing base (08e55b9) to head (8e62028).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1786 +/- ## ========================================== + Coverage 79.00% 79.13% +0.13% ========================================== Files 94 94 Lines 21077 21077 ========================================== + Hits 16651 16680 +29 + Misses 4426 4397 -29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdamore commented 7 months ago

I'm going to merge this... I think it is probably the right fix. Please let me know if this for any reason not fix the issue.