release tarball for version 1.9.0 has wrong include version number

nanomsg / nng

nanomsg-next-generation -- light-weight brokerless messaging

https://nng.nanomsg.org

MIT License

3.85k stars 490 forks source link

Open efferre79 opened 2 days ago

efferre79 commented 2 days ago

Describe the bug Looking inside the tarball, include/nng/nng.h file defines:

#define NNG_MAJOR_VERSION 1
#define NNG_MINOR_VERSION 8
#define NNG_PATCH_VERSION 0

Expected behavior The version should be 1.9.0

Actual Behavior The version is 1.8.0 which leads installing /usr/lib64/libnng.so.1.8.0 file on Linux.

gdamore commented 2 days ago

Yes, I'm aware. It was a goof on my part.

I'm getting ready to release a 1.10 soon that will introduce some new APIs to aid transitioning to 2.0. So it will be fixed then.