Closed dk515 closed 3 years ago
I branched off and started rolling back. The problem appears at commit fc65cb1 and is caused by a change in argument order in function Group.create_dataset
in datafile.py, which is called by the function append_dataset
that I was using. Setting the order back to what it was before resolves the problem.
I think we should roll back and keep the argument order as it was originally before fc65cb1 since the current order breaks my experiment, and it would also be consistent with the h5py library we are using, which is probably why it was implemented with that order in the first place. Do you agree @eoinell @mjh250 ? I'm happy to make the commit for that.
My first ever issue report, please bear with me and let me know if I'm not doing this right. In my experiment code I am using
nplab.datafile.append_dataset
to save some data, but it is now throwing an exception. Code to reproduce:traceback
``` Traceback (most recent call last): File "C:\Users\...\datafile_test.py", line 13, inAny ideas? It was working fine a couple of months ago. h5py version is 2.8, nplab repo is up to date.