search

nanophotonics / nplab

Core functions and instrument scripts for the Nanophotonics lab experimental scripts
GNU General Public License v3.0
38 stars 15 forks source link

Py38 #137

Closed eoinell closed 3 years ago

eoinell commented 3 years ago

Can you guys have a double check this does the job? The whole architecture could definitely be simpler for sure though

YagoDel commented 3 years ago

I can't comment on the Trandor stuff. The ImageView stuff I hope gets superseded by #136

YagoDel commented 3 years ago

For imageview.py, the levelling of each individual image doesn't work. I've fixed this in #136 If you're happy with the Renderers and the Trandor code, please merge this into master, and then we can merge #136 to fix imageview.py

YagoDel commented 3 years ago

I haven't looked at the merge conflicts yet, but I'm fairly certain they are from #135 and #120, which should take priority in the merge