nanophotonics / nplab

Core functions and instrument scripts for the Nanophotonics lab experimental scripts
GNU General Public License v3.0
38 stars 15 forks source link

Random track for andor #139

Closed eoinell closed 2 years ago

eoinell commented 3 years ago

I couldn't quite work out how to use a c-array of variable size as an input for SetRandomTracks within the existing parameter-based framework. Is this possible, or would it need extension? This approach works, but obviously it could be a bit more concise

eoinell commented 3 years ago

On a side note, do you know if random/multi-track/image mode can be used in kinetic mode? The difference in performance may not be worth the effort anyway

YagoDel commented 3 years ago

I had a quick look at the SDK, and it seems that RandomTrack is the only parameter that can takes a pointer as an input, so the _dll_wrapper won't know what to do with it. I can probably simplify it, so we have something like: RandomTrack=dict(Set=dict(cmdName='SetRandomTracks', Inputs=(c_int, c_pointer),)) and hence not clutter the methods, but it would take me more time than I have right now.

If you need this in master now, go for it and merge it: there's nothing that'll crash any existing experiments. But if you don't need it now, I'll give it some time at the beginning of next week

YagoDel commented 3 years ago

Kinetic mode should work with all ReadModes (FastKinetic won't though)