nanoporetech / medaka

Sequence correction provided by ONT Research
https://nanoporetech.com
Other
391 stars 73 forks source link

test suite generates untracked files #378

Closed tkonopka closed 10 months ago

tkonopka commented 1 year ago

Describe the bug

Running make test creates untracked files in the repository root, which is unexpected.

.coverage
data.pickle
test_hap1.vcf
test_hap2.vcf
test_ref.fasta

Logging

NA

Environment (if you do not have a GPU, write No GPU):

Additional context

Would it be alright to include .coverage in .gitignore?

As far as I can tell, the other files are not needed to run the test suite, and it would be strange if they were needed elsewhere. Would it be alright to remove these?

I can prepare a PR with these changes if you agree.

cjw85 commented 1 year ago

@mwykes Would be good to track from which tests these are coming and make sure they are being written to a proper tempdir.

cjw85 commented 10 months ago

I have fixed this on our development branch.