nanoporetech / medaka

Sequence correction provided by ONT Research
https://nanoporetech.com
Other
423 stars 74 forks source link

Polishing a GFA #427

Open mmcguffi opened 1 year ago

mmcguffi commented 1 year ago

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Thanks for the great tool!

cjw85 commented 1 year ago

The simple question first: contigs are never merged during polishing.

It is unlikely that we will ever implement GFA output. I'd have to refresh my memory of the details of GFA but I believe outputting an updated GFA would require recomputing connections and overlaps between the contigs. This is not a trivial operation when the contigs have changed length (as they do during polishing, and we wish to keep containments). If there is a library out there that implements such transformations (possibly something akin to liftover), then in might be possible to embed into medaka. Otherwise it would be a task of a standalone tool.

cjw85 commented 1 year ago

Hmmm, even in the case of simple links care would need to be taken in implementing this because medaka can arbitrarily extend contigs ends (not starts). This could have subtle and weird effects on the interpretation of the GFA.

mmcguffi commented 1 month ago

Any chance you would implement medaka gfa polishing? This remains a hassle for several of our pipelines