Cors and minknow_api - Githubissues

nanoporetech / minknow_api

Protobuf and gRPC specifications for the MinKNOW API

Other

50 stars 12 forks source link

Cors and minknow_api #23

Closed orel509 closed 3 years ago

orel509 commented 3 years ago

Hello, I wanted to know if the web version of minknow_api supports CORS or is it not possible to use the minknow_api through different origins?

0x55555555 commented 3 years ago

Hello @orel509,

We have fixed this in the most recent release, due to ship to customers shortly.

Hope this helps,

George

orel509 commented 3 years ago

Hello @orel509,

We have fixed this in the most recent release, due to ship to customers shortly.

Hope this helps,
* George

fixed what? does it support it now or is it not allowed? And do you maybe have an estimated date? thank you in advance.

0x55555555 commented 3 years ago

The next release will include specific options (--allow_all_origins) to all the grpc web proxies (https://github.com/improbable-eng/grpc-web) used to host web grpc connections to minknow. This should fix any CORS issues.

I'm unable to give a date, we are working to ship as quickly as possible.