search

nanoporetech / minknow_api

Protobuf and gRPC specifications for the MinKNOW API
Other
50 stars 12 forks source link

Protocols "make_protocol_arguments" throws exception if no additional args are provided #62

Open ChristopherAdelmann opened 6 months ago

ChristopherAdelmann commented 6 months ago

When utilizing protocols.start_protocol or make_protocol_arguments directly, an error is thrown during the execution of the function when argsis set to None. To enhance the robustness of the code, a simple solution would be to incorporate a conditional check to verify if args is None before proceeding with the extension of protocol arguments.

Best regards, Christopher

0x55555555 commented 6 months ago

Hi @ChristopherAdelmann,

Thanks for the report - we will take a look asap!