search

nanoporetech / ont_fast5_api

Oxford Nanopore Technologies fast5 API software
Other
145 stars 28 forks source link

--recursive in compress_fast5 #28

Closed pterzian closed 4 years ago

pterzian commented 4 years ago

Hi,

Could you confirm that the --recursive option doesn't take any boolean parameter instead of what is stated in the example usage :

compress_fast5 --input_path /data/uncompressed_reads --save_path /data/compressed_reads
    --compression vbz --recursive True --threads 40

This returns the unrecognized arguments: True error.

Does calling the option as the following set --recursive to True and not to False (it is stated default=False) : 

compress_fast5 --input_path /data/uncompressed_reads --save_path /data/compressed_reads
    --compression vbz --recursive --threads 40

Paul

fbrennen commented 4 years ago

Hi @pterzian -- apologies, you're entirely correct: --recursive does not take an argument, and by default is disabled. Your second example correctly enables recursive folder navigation.

We'll get this fixed.

davidnewman02 commented 4 years ago

This has been fixed in v3.0