search

nanoporetech / ont_fast5_api

Oxford Nanopore Technologies fast5 API software
Other
144 stars 28 forks source link

[M]: add tombo resquiggle #49

Closed loganylchen closed 3 years ago

loganylchen commented 3 years ago

Which was widely used in raw signal manipulation.

loganylchen commented 3 years ago

Hi there,

I think if I refer this github code, which would be helpful.

https://github.com/nanoporetech/tombo/blob/master/tombo/_option_parsers.py#L100-102

loganylchen commented 3 years ago

May I ask if this could be merged?

fbrennen commented 3 years ago

Hi @btrspg -- is this to fix a particular bug in tombo, or is there another reason you'd like it in here?

loganylchen commented 3 years ago

Hi @fbrennen,

No, it has nothing to do with the tombo. As the tombo-resquiggle module also writes results into the fast5 file, I thought it's better to manipulate that results by ont_fast5_api. As you know, tombo was widely used when encountered modifications detection. Let me know if you have any other wonders.

Best,

fbrennen commented 3 years ago

Alrighty, sounds ok to me -- just wanted to check first.