Use pyranges for overlap logic

nanoporetech / pore-c

Pore-C support

Mozilla Public License 2.0

52 stars 5 forks source link

Open eharr opened 4 years ago

eharr commented 4 years ago

Some of the overlap logic implemented in GenomeIntervalDf could be replaced with calls to the better documented and tested pyranges api.

endrebak commented 4 years ago

Actually, the NCLS is tested extensively in the pyranges tests, but indirectly.

eharr commented 4 years ago

Actually, the NCLS is tested extensively in the pyranges tests, but indirectly. Ah sorry, I meant better tested than the pore-c implementation.

endrebak commented 4 years ago

Also, I would love to help out if you have reasonable feature-requests for pyranges. Or feel free to ping me for help :)