Custom Classes not passed properly into events

[vugi99]

Prerequisites

• [X] I'm sure both client and server are on the latest update.
• [X] I have read the console error message carefully (if applicable).

Your Environment

• Version: 1.49.0
• Operating System: Windows 11

Description

Custom Classes not passed properly into events

Steps to reproduce the behavior

Grab the vbot package

and do this in another package :

local bot1 = VBotJoin()

print(bot1:GetControlledCharacter())
Events.Subscribe("TestPass", function(bot)
print(bot:GetControlledCharacter())
end)
Events.Call("TestPass", bot1)

Expected behavior

Should keep the class methods

Actual behavior

[vugi99]

Seems like this is a very old issue Should be reconsidered now that we have the new VM thing... (you can clearly pass the functions and it shouldn't be a problem now)

For remote events i'm unsure what you could do there. (I can kinda fix it myself anyway so there's something to do but it's much more complicated in this case)

[gtnardy]

yeah I guess this never worked, because Events is passing the bot table as parameter, and it is being serialized/deserialized in the call, so it loses the metatable and so on

[vugi99]

Should be looked into as I said If you don't want to implement it I'll use Modularity to do that properly...

[gtnardy]

I would say to you to use the new Inheriting System instead, I don't think I will take a look that soon because it changes a lot of things

[vugi99]

Inheriting from Player ??? Doesn't sound like a good idea, nanos will probably stop me when trying that.

[gtnardy]

you probably could try making it inheriting from Character

[vugi99]

It doesn't share any method so that's not the way. I'll just wrap any Events.Subscribe and Events.SubscribeRemote function to set the metatable again if a bot is in the arguments

[vugi99]

Modularity will allow that in a future update I’ll introduce a self made events system