nanos-world / issues

Issue Tracker for nanos world
9 stars 1 forks source link

Package.Require("package_name/...") sources being weird in debug info #919

Closed vugi99 closed 1 year ago

vugi99 commented 1 year ago

Prerequisites

Your Environment

Description

Code required that comes from other packages have a weird source string when functions from those files are called

Steps to reproduce the behavior

Packages with minimal code : https://cdn.discordapp.com/attachments/870019607333838878/1121044388563406908/modularity_injection.rar

How to run it : image

Expected behavior

I would like : modularity-empty/Shared/modularity-injection/Shared/… Or modularity-empty/../modularity-injection/Shared/...

Actual behavior

Debug calls show this source on 1.56.2 : modularity-empty/on/Shared/Index.lua

gtnardy commented 1 year ago

Can you try this again in the next build with the fix I did for https://github.com/nanos-world/issues/issues/924?

vugi99 commented 1 year ago

Sure

vugi99 commented 1 year ago

The source is correct now. Let me see if I can implement the feature now, i'll get back here later.

gtnardy commented 1 year ago

did it also fix that weird /on/ ?

vugi99 commented 1 year ago

It's now the real path without any .. or the host package name in it. There's still something that I don't get in your Package.RequirePackage fix. Gonna @ you on discord.

vugi99 commented 1 year ago

The path is correct now so I close the issue even tho it’s not what I needed.