nanos-world / issues

Issue Tracker for nanos world
9 stars 1 forks source link

`SceneCapture:EncodeToBase64` client crash when scene capture resolution is too high #960

Closed Timmy-the-nobody closed 1 year ago

Timmy-the-nobody commented 1 year ago

Prerequisites

Your Environment

Description

SceneCapture:EncodeToBase64 makes the client crash when scene capture resolution is too high

Steps to reproduce the behavior

  1. Create a scene capture with crazy resolution (3000x3000)
  2. Encode the scene capture to base 64
  3. Chaos

Expected behavior

Shouldn't crash, or at least clamp the resolution of the scene capture before encoding when crazy values are used

Actual behavior

Freeze and crash with crazy scene capture resolutions

gtnardy commented 1 year ago

did you get a crash report?

Timmy-the-nobody commented 1 year ago

It wasn't me who had the problem but it was Aerox I just offered to open the issue, but from what he told me he had a windows crash

Timmy-the-nobody commented 1 year ago

@kilian-guerin if you have more details about it can you post it here please?

aeroxfr commented 1 year ago

Hi, I simply changed the resolution of my SceneCapture to 10000 for example, I simply crashed because the file was much too large to load.

image

I couldn't get a crash report, my client made me crash my computer.

gtnardy commented 1 year ago

thanks for that! but it only crashed after generating the base 64 string?

aeroxfr commented 1 year ago

Yes, when I initialize it and load it onto my client.

gtnardy commented 1 year ago

I will limit the size of it to prevent the crash