User can't toggle a stance mode bind once it's set by scripting

[Timmy-the-nobody]

Prerequisites

• [X] I'm sure both client and server are on the latest update.
• [X] I have read the console error message carefully (if applicable).

Your Environment

• Version: 1.64.9
• Operating System: Windows 11

Description

The key binded to toggle a stance mode becomes unusable for a stance mode that was set by scripting

Steps to reproduce the behavior

1: If you have "lua_run" package, type this in your server console: lua_run Character.GetByIndex(1):SetStanceMode(StanceMode.Crouching) (replace the index by your controlled character index)

2: Then try to press the "Crouch" keybind (it should be broken)

3: Toggle the keybind of another stance mode (like "Prone") will "fix" the issue

This issue isn't only visible with StanceMode.Crouching, if you set the stance mode via scripting to another stance, like StanceMode.Proning, you'll be able to observer the same behaviour (prone toggle locked from client binds)

Expected behavior

The client shouldn't be blocked from toggling it's controlled character stance mode after the stance mode was changed by scripting

Actual behavior

Changing the stance mode of a character via scripting makes the toggle ignore client inputs

[gtnardy]

I did a quick fix for this that will work for now, this whole "Modes" system is quite dirty and would need a big refactor

[Timmy-the-nobody]

I did a quick fix for this that will work for now, this whole "Modes" system is quite dirty and would need a big refactor

Thank you! I'll take a look soon