search

nanos / FediFetcher

FediFetcher is a tool for Mastodon that automatically fetches missing replies and posts from other fediverse instances, and adds them to your own Mastodon instance.
https://blog.thms.uk/fedifetcher?utm_source=github
MIT License
296 stars 215 forks source link

Parsing error #2

Closed quicoto closed 1 year ago

quicoto commented 1 year ago

I got another build fail when parsing a URL

Not sure if we can catch these as well, following up on #1

https://github.com/quicoto/mastodon-get-replies/actions/runs/4362831948/jobs/7628194627

Thank you

nanos commented 1 year ago

That error message is almost certainly a red herring: The very fact that it says there was an error, indicates the the error was caught.

As far as I can see this only happened once? I wonder if this was an OOM, or if GitHub killed the job for another reason 🤔

quicoto commented 1 year ago

No idea, just wanted to raise this in case was something on our side we could improve.

Feel free to close if not relevant

Thank you for having a look

nanos commented 1 year ago

I would say let's observe for now. Let me know if it happens again, and I might add some more logging to that part of the script to see where exactly it fails.

quicoto commented 1 year ago

Another fail, different message I think

https://github.com/quicoto/mastodon-get-replies/actions/runs/4363887432/jobs/7630534273

nanos commented 1 year ago

thanks, yes. I will need to handle this more gracefully

nanos commented 1 year ago

the latest change should fix this.

nanos commented 1 year ago

@quicoto Please make sure you are at least on version 2.0.1. Fixed an important bug there.

(I've also re-written the action, so that future versions shouldn't need you to update your fork, as the action now downloads the latest version automatically for every run.)

quicoto commented 1 year ago

@nanos Updated to the latest, Thank you !

https://github.com/quicoto/mastodon-get-replies/tree/main