search

nanovms / ops

ops - build and run nanos unikernels
https://ops.city
MIT License
1.3k stars 132 forks source link

package is missing name field #1257

Closed eyberg closed 2 years ago

eyberg commented 2 years ago

https://github.com/nanovms/ops/blob/master/lepton/package.go#L34

this is probably just from the legacy fact that we never really explicitly had it to begin with (just using the ProgramName from manifest) - def worth having now espc after the next build gets cut

girish-nanovms commented 2 years ago

what should be done here @eyberg ?

girish-nanovms commented 2 years ago

should we add the name to package.manifest of all packages present in pkghub

eyberg commented 2 years ago

I think https://github.com/nanovms/ops/commit/f7cc685704e7f92a8ac68d552fbd15b81a636214 closes this