Closed eyberg closed 2 years ago
=== RUN TestBuildImageFlagsMergeToConfig/should_merge_flags_into_configuration 2022/03/31 01:14:15 volume: volwo94Z created with UUID 063e12a6-0ac6-131e-abb5-b4c03f495ff1 and label volwo94Z flags_build_image_test.go:96: Error Trace: flags_build_image_test.go:96 Error: Not equal: expected: &types.Config{Args:[]string{"MyTestApp", "a b c d"}, DisableArgsCopy:false, BaseVolumeSz:"", Boot:"/home/circleci/.ops/0.1.39/boot.img", UefiBoot:"", Uefi:false, BuildDir:"", CloudConfig:types.ProviderConfig{BucketName:"", BucketNamespace:"", DomainName:"", StaticIP:"", EnableIPv6:false, Flavor:"", ImageType:"", ImageName:"test-image", InstanceProfile:"", Platform:"", ProjectID:"", SecurityGroup:"", Subnet:"", Tags:[]types.Tag(nil), VPC:"", Zone:""}, Debugflags:[]string(nil), Dirs:[]string(nil), Env:map[string]string{"test":"1234"}, Files:[]string(nil), Force:false, Kernel:"/home/circleci/.ops/0.1.39/kernel.img", KlibDir:"", MapDirs:map[string]string(nil), Mounts:map[string]string{"volwo94Z":"/files"}, NameServers:[]string{"8.8.8.8"}, NanosVersion:"", NightlyBuild:false, NoTrace:[]string(nil), ManifestPassthrough:map[string]interface {}{}, Program:"MyTestApp", ProgramPath:"", RebootOnExit:false, RunConfig:types.RunConfig{Accel:false, Bridged:false, BridgeName:"", CPUs:0, Debug:false, Gateway:"", GdbPort:0, Imagename:"/home/circleci/.ops/images/test-image.img", InstanceGroup:"", InstanceName:"", IPAddress:"", IPv6Address:"", Klibs:[]string(nil), Memory:"", Vga:false, Mounts:[]string(nil), NetMask:"255.255.255.0", Background:false, Ports:[]string(nil), ShowDebug:false, ShowErrors:false, ShowWarnings:false, JSON:false, TapName:"", UDPPorts:[]string(nil), Verbose:false, VolumeSizeInGb:0}, LocalFilesParentDirectory:"", TargetRoot:"unix", Version:"", Language:"", Runtime:"", Description:"", VolumesDir:"/home/circleci/.ops/volumes", PackageBaseURL:"", PackageManifestURL:""} actual : &types.Config{Args:[]string{"MyTestApp", "a b c d"}, DisableArgsCopy:false, BaseVolumeSz:"", Boot:"/home/circleci/.ops/0.1.39/boot.img", UefiBoot:"/home/circleci/.ops/0.1.39/bootx64.efi", Uefi:false, BuildDir:"", CloudConfig:types.ProviderConfig{BucketName:"", BucketNamespace:"", DomainName:"", StaticIP:"", EnableIPv6:false, Flavor:"", ImageType:"", ImageName:"test-image", InstanceProfile:"", Platform:"", ProjectID:"", SecurityGroup:"", Subnet:"", Tags:[]types.Tag(nil), VPC:"", Zone:""}, Debugflags:[]string(nil), Dirs:[]string(nil), Env:map[string]string{"test":"1234"}, Files:[]string(nil), Force:false, Kernel:"/home/circleci/.ops/0.1.39/kernel.img", KlibDir:"", MapDirs:map[string]string(nil), Mounts:map[string]string{"volwo94Z":"/files"}, NameServers:[]string{"8.8.8.8"}, NanosVersion:"", NightlyBuild:false, NoTrace:[]string(nil), ManifestPassthrough:map[string]interface {}{}, Program:"MyTestApp", ProgramPath:"", RebootOnExit:false, RunConfig:types.RunConfig{Accel:false, Bridged:false, BridgeName:"", CPUs:0, Debug:false, Gateway:"", GdbPort:0, Imagename:"/home/circleci/.ops/images/test-image.img", InstanceGroup:"", InstanceName:"", IPAddress:"", IPv6Address:"", Klibs:[]string(nil), Memory:"", Vga:false, Mounts:[]string(nil), NetMask:"255.255.255.0", Background:false, Ports:[]string(nil), ShowDebug:false, ShowErrors:false, ShowWarnings:false, JSON:false, TapName:"", UDPPorts:[]string(nil), Verbose:false, VolumeSizeInGb:0}, LocalFilesParentDirectory:"", TargetRoot:"unix", Version:"", Language:"", Runtime:"", Description:"", VolumesDir:"/home/circleci/.ops/volumes", PackageBaseURL:"", PackageManifestURL:""} Diff: --- Expected +++ Actual @@ -8,3 +8,3 @@ Boot: (string) (len=35) "/home/circleci/.ops/0.1.39/boot.img", - UefiBoot: (string) "", + UefiBoot: (string) (len=38) "/home/circleci/.ops/0.1.39/bootx64.efi", Uefi: (bool) false, Test: TestBuildImageFlagsMergeToConfig/should_merge_flags_into_configuration === RUN TestBuildImageFlagsMergeToConfig/should_clear_ip/gateway/netmask_if_they_are_not_valid_ip_addresses flags_build_image_test.go:126: Error Trace: flags_build_image_test.go:126 Error: Not equal: expected: &types.Config{Args:[]string{}, DisableArgsCopy:false, BaseVolumeSz:"", Boot:"/home/circleci/.ops/0.1.39/boot.img", UefiBoot:"", Uefi:false, BuildDir:"", CloudConfig:types.ProviderConfig{BucketName:"", BucketNamespace:"", DomainName:"", StaticIP:"", EnableIPv6:false, Flavor:"", ImageType:"", ImageName:"", InstanceProfile:"", Platform:"", ProjectID:"", SecurityGroup:"", Subnet:"", Tags:[]types.Tag(nil), VPC:"", Zone:""}, Debugflags:[]string(nil), Dirs:[]string(nil), Env:map[string]string(nil), Files:[]string(nil), Force:false, Kernel:"/home/circleci/.ops/0.1.39/kernel.img", KlibDir:"", MapDirs:map[string]string(nil), Mounts:map[string]string{}, NameServers:[]string{"8.8.8.8"}, NanosVersion:"", NightlyBuild:false, NoTrace:[]string(nil), ManifestPassthrough:map[string]interface {}{}, Program:"", ProgramPath:"", RebootOnExit:false, RunConfig:types.RunConfig{Accel:false, Bridged:false, BridgeName:"", CPUs:0, Debug:false, Gateway:"", GdbPort:0, Imagename:"", InstanceGroup:"", InstanceName:"", IPAddress:"", IPv6Address:"", Klibs:[]string(nil), Memory:"", Vga:false, Mounts:[]string(nil), NetMask:"", Background:false, Ports:[]string(nil), ShowDebug:false, ShowErrors:false, ShowWarnings:false, JSON:false, TapName:"", UDPPorts:[]string(nil), Verbose:false, VolumeSizeInGb:0}, LocalFilesParentDirectory:"", TargetRoot:"", Version:"", Language:"", Runtime:"", Description:"", VolumesDir:"", PackageBaseURL:"", PackageManifestURL:""} actual : &types.Config{Args:[]string{}, DisableArgsCopy:false, BaseVolumeSz:"", Boot:"/home/circleci/.ops/0.1.39/boot.img", UefiBoot:"/home/circleci/.ops/0.1.39/bootx64.efi", Uefi:false, BuildDir:"", CloudConfig:types.ProviderConfig{BucketName:"", BucketNamespace:"", DomainName:"", StaticIP:"", EnableIPv6:false, Flavor:"", ImageType:"", ImageName:"", InstanceProfile:"", Platform:"", ProjectID:"", SecurityGroup:"", Subnet:"", Tags:[]types.Tag(nil), VPC:"", Zone:""}, Debugflags:[]string(nil), Dirs:[]string(nil), Env:map[string]string(nil), Files:[]string(nil), Force:false, Kernel:"/home/circleci/.ops/0.1.39/kernel.img", KlibDir:"", MapDirs:map[string]string(nil), Mounts:map[string]string{}, NameServers:[]string{"8.8.8.8"}, NanosVersion:"", NightlyBuild:false, NoTrace:[]string(nil), ManifestPassthrough:map[string]interface {}{}, Program:"", ProgramPath:"", RebootOnExit:false, RunConfig:types.RunConfig{Accel:false, Bridged:false, BridgeName:"", CPUs:0, Debug:false, Gateway:"", GdbPort:0, Imagename:"", InstanceGroup:"", InstanceName:"", IPAddress:"", IPv6Address:"", Klibs:[]string(nil), Memory:"", Vga:false, Mounts:[]string(nil), NetMask:"", Background:false, Ports:[]string(nil), ShowDebug:false, ShowErrors:false, ShowWarnings:false, JSON:false, TapName:"", UDPPorts:[]string(nil), Verbose:false, VolumeSizeInGb:0}, LocalFilesParentDirectory:"", TargetRoot:"", Version:"", Language:"", Runtime:"", Description:"", VolumesDir:"", PackageBaseURL:"", PackageManifestURL:""} Diff: --- Expected +++ Actual @@ -6,3 +6,3 @@ Boot: (string) (len=35) "/home/circleci/.ops/0.1.39/boot.img", - UefiBoot: (string) "", + UefiBoot: (string) (len=38) "/home/circleci/.ops/0.1.39/bootx64.efi", Uefi: (bool) false, Test: TestBuildImageFlagsMergeToConfig/should_clear_ip/gateway/netmask_if_they_are_not_valid_ip_addresses --- FAIL: TestBuildImageFlagsMergeToConfig (0.00s) --- FAIL: TestBuildImageFlagsMergeToConfig/should_merge_flags_into_configuration (0.00s) --- FAIL: TestBuildImageFlagsMergeToConfig/should_clear_ip/gateway/netmask_if_they_are_not_valid_ip_addresses (0.00s) === RUN TestConfigFlags --- PASS: TestConfigFlags (0.00s)
Fixed by #1311