search

nanovms / ops

ops - build and run nanos unikernels
https://ops.city
MIT License
1.27k stars 132 forks source link

AWS images: set ENA support to true regardless of instance type #1518

Closed francescolavra closed 1 year ago

francescolavra commented 1 year ago

The EnaSupport flag of the ec2.RegisterImageInput structure indicates the the OS in an image has an ENA driver, not that it requires an ENA device; thus, an image flagged as ENA-capable can run just fine on AWS instances without an ENA adapter (such as non-Nitro instance types). This change removes the NitroInstanceTypes map and the GetEnaSupportForFlavor() function, and sets the EnaSupport flag to true regardless of the instance type. This allows creating images that can run on newer Nitro instance types such as m7a, m7i and r7iz.

francescolavra commented 1 year ago

AWS images registered by Ops are always HVM AMIs, regardless on the instance types - https://github.com/nanovms/ops/blob/4f8ac6fa66e4f75d76bb2cf8eb20c78f42a5ea81/provider/aws/aws_image.go#L153

eyberg commented 1 year ago

ah ok, lgtm