nanovms / ops

ops - build and run nanos unikernels
https://ops.city
MIT License
1.3k stars 132 forks source link

Ops deploy does not use InstanceName on DO #1579

Closed hnord-vdx closed 9 months ago

hnord-vdx commented 9 months ago

When configuring the instance name in config.json and deploying both the image and instance via ops deploy, the instance name defaults to the concatenation of the image name and the Unix timestamp.

Sample config file

{
    "CloudConfig": {
      "ImageName": "$IMAGE_NAME",
    },
    "RunConfig": {
      "Imagename": "$IMAGE_NAME",
      "InstanceName": "$INSTANCE_NAME",
}

Note: I am setting the ops_render_config: true env var

Is this the expected behaviour when using deploy?

eyberg commented 9 months ago

the instance name default is the image name && timestamp but this was a bug where it was only setting it via cli flag not config, fixed via https://github.com/nanovms/ops/pull/1581