search

nanovna-v2 / NanoVNA2-firmware

Firmware for NanoVNA V2
https://nanorfe.com/nanovna-v2.html
222 stars 87 forks source link

Calibration status not clear when redoing #15

Closed Mike4U closed 4 years ago

Mike4U commented 4 years ago

git-20200507-7980406 The open, short,load,thru buttons correctly highlight when they're done. However when you redo one of these there is no indication it has started or when it's done.

Perhaps pressing a highlighted ops,l,t button should unhighlight it until it is finished again.

DiSlord commented 4 years ago

You not fully fix this issue, i fix it in This commit from my patch https://github.com/nanovna/NanoVNA-V2-firmware/pull/23/commits/3f7691beb30e621bd9193993d32c1f8ec69cbef0 For new UI https://github.com/nanovna/NanoVNA-V2-firmware/pull/23

douardda commented 4 years ago

Since @DiSlord PR has been merged, can this issue be closed now?

DiSlord commented 4 years ago

I think yes. Now calibration show SOLT status, and it update on made.

Mike4U commented 4 years ago

The 20200525 release does not fix the issue. Also a 20200617 version gabriel linked somewhere does not fix. I haven't tried to compile the DiSlord merge. Is a binary available somewhere?

DG9BFC commented 4 years ago

issue can be closed i think a different colour (say button is red ... blinks while doing calib and switches to light green) when redo blinks again and switches again to green when finished? the 3d buttons are nice ... but outdoors in daylight the button selected in light green (see fw from ojisan) is much easier to see ... so what about a general gui colour change (button in green) ... then also calib could change colour (and blink while redo'??)

Mike4U commented 4 years ago

Seems to be fixed in git 20201013-32077fd.

thanks