Can't find ep if ep is 0

Mythologyli commented 1 year ago

Example: Mushoku.Tensei.Isekai.Ittara.Honki.Dasu.S02E00.2023.1080p.CR.WEB-DL.x264.AAC-ADWeb.mkv https://bgm.tv/ep/1212094

Result:

Check ./Mushoku.Tensei.Isekai.Ittara.Honki.Dasu.S02.2023.1080p.CR.WEB-DL.x264.AAC-ADWeb ...
    Parse config file
      Fetch anime data for: [373247] 無職転生Ⅱ ～異世界行ったら本気だす～ / 无职转生Ⅱ ～到了异世界就拿出真本事～
        Generate ./Mushoku.Tensei.Isekai.Ittara.Honki.Dasu.S02.2023.1080p.CR.WEB-DL.x264.AAC-ADWeb/Mushoku.Tensei.Isekai.Ittara.Honki.Dasu.S02E00.2023.1080p.CR.WEB-DL.x264.AAC-ADWeb.nfo ...
    Failed: Can't find ep , is_sp false
Can't find ep , is_sp false

After I read the code, I found that in job.rs:

let ep: String = match caps.as_ref().and_then(|c| c.name("ep")) {
            Some(ep_match) => {
                String::from(ep_match.as_str().parse::<String>()?.trim_start_matches('0'))
            }
            None => return Ok(None),
        };

trim_start_matches('0') trims all 0, then ep is "".

nanozuki commented 1 year ago

Thanks for feedback, I'll fix this in this week.

nanozuki commented 1 year ago

solved by https://github.com/nanozuki/dantalian/pull/57 , version 0.4.4

nanozuki / dantalian

Can't find ep if ep is 0 #55