nanozuki / tabby.nvim

A declarative, highly configurable, and neovim style tabline plugin. Use your nvim tabs as a workspace multiplexer!
MIT License
563 stars 21 forks source link

Tabline Background Seems Corrupted #109

Closed mebaran closed 1 year ago

mebaran commented 1 year ago

I really like this plugin except I have weird white bars that make the tab bar look ugly. I'm using the Seoul256 theme for these screenshots (both with and without nerdfonts). How can I fix it? Attached images show issue.

tabby nvim look problem 2 tabby nvim tab look problem

Neovim Info:

:version NVIM v0.8.3 Build type: Release LuaJIT 2.1.0-beta3 Compiled by runner@fv-az183-550

Features: +acl +iconv +tui See ":help feature-compile"

system vimrc file: "$VIM/sysinit.vim" fall-back for $VIM: "/share/nvim"

Run :checkhealth for more info

nanozuki commented 1 year ago

Can you tell me the config of tabby?

mebaran commented 1 year ago

Here's my config for statuslines:

local function lualine_setup ()
    require('lualine').setup({
        globalstatus = true
    })
end

local function tabby_setup ()
    require('tabby.tabline').use_preset('active_wins_at_tail')
end

return {
    {
        "nvim-lualine/lualine.nvim",
        config = lualine_setup
    },
    {
        "nanozuki/tabby.nvim",
        config = tabby_setup
    }
}
nanozuki commented 1 year ago

I found that highlights of the theme 'Seoul256' set are not completed for tabby's separator. So the separator color is wrong. You can apply a theme object to the preset. I found a valid value by follow the lualine's theme:

require('tabby.tabline').use_preset('active_wins_at_tail', {
  theme = {
    fill = 'Visual',
    tab = 'StatusLine',
    win = 'StatusLine',
    head = 'StatusLine',
    tail = 'StatusLine',
  },
})

The preview is:

image

You can use :highlight command to choose what highlight you want to use. Or you can specify the color from Seoul256's color palette, for example:

require('tabby.tabline').use_preset('active_wins_at_tail', {
  theme = {
    ...
    tab = { fg = '#dfe0e0',  guibg=#545454 },
    ...
  },
})
mebaran commented 1 year ago

This worked perfectly. I noticed this issue in several other themes; maybe it would make sense to make it a theme fix up option for lualine users? Now the plugin works great!

Best, Mark

On Wed, Mar 1, 2023 at 1:50 AM crows @.***> wrote:

I found that highlights of the theme 'Seoul256' set are not completed for tabby's separator. So the separator color is wrong. You can apply a theme object to the preset. I found a valid value by follow the lualine's theme:

require('tabby.tabline').use_preset('active_wins_at_tail', { theme = { fill = 'Visual', tab = 'StatusLine', win = 'StatusLine', head = 'StatusLine', tail = 'StatusLine', }, })

The preview is:

[image: image] https://user-images.githubusercontent.com/4208028/222059499-31f272e0-2f69-428f-a2bf-9e44d6cec669.png

You can use :highlight command to choose what highlight you want to use. Or you can specify the color from Seoul256's color palette, for example:

require('tabby.tabline').use_preset('active_wins_at_tail', { theme = { ... tab = { fg = '#dfe0e0', guibg=#545454 }, ... }, })

— Reply to this email directly, view it on GitHub https://github.com/nanozuki/tabby.nvim/issues/109#issuecomment-1449442507, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQJISTAELG7PLNIF7QQUTWZ3WSPANCNFSM6AAAAAAVI2BELA . You are receiving this because you authored the thread.Message ID: @.***>

nanozuki commented 1 year ago

I'm glad it helps.

maybe it would make sense to make it a theme fix up option for lualine users?

Oh! I think this is a justifiable suggestion since the lualine looks like the most popular line plugin.

nanozuki commented 11 months ago

@mebaran After version v2.2.0, the user can use Lualine's theme in presets.