search

nanozuki / tabby.nvim

A declarative, highly configurable, and neovim style tabline plugin. Use your nvim tabs as a workspace multiplexer!
MIT License
607 stars 21 forks source link

About the highlight extraction routine #118

Closed TinusgragLin closed 1 year ago

TinusgragLin commented 1 year ago

I recently switched my color scheme to gruvbox.nvim and noticed that the separators turned white: 2023-08-05_20-13-49

I compared highlight settings of gruvbox.nvim with that of other color schemes and suspected that Tabline being linked to TablineFill might be the problem, then I further checked tabby's source code and noticed that highlight.extract does not handle highlight linking.

While this can be fixed easily, I wonder why we are not using nvim_get_hl to extract information about a certain highlight group as it is simpler and more reliable.

nanozuki commented 1 year ago

Oh..., I write the plugin when nvim 0.5.0. In that version, there is no nvim_get_hl. Since the neovim 0.9 is already released some days, I think this project should use more lua APIs.

Thanks for your reminder, I try to fix this.

nanozuki commented 1 year ago

nvim_get_hl and nvim_set_hl will import breaking updates in the current version. I will put them in next version. So I fixed this issue in old way (match string). I will open another issue to make tabby.nvim to use pure lua api.