search

nanozuki / tabby.nvim

A declarative, highly configurable, and neovim style tabline plugin. Use your nvim tabs as a workspace multiplexer!
MIT License
570 stars 20 forks source link

feat: colors module provide function instead of value #73

Closed nanozuki closed 2 years ago

ehrand commented 2 years ago

With this change my colorscheme is not respected anymore. Searching for some hints in docs did not provide any help yet. Reverting back to commit c48af54a397bdae0f86e7000d35455bafcfa4a45 fixes the problem for me. Is there some way available to make this plugin (which I really love) follow my colorscheme?

nanozuki commented 2 years ago

@ehrand Oh, I'm sorry for that. I change the default colors because some color schemes do not set a good highlight group for TabLine, TabLineSel, and TabLineFill. So I use color from terminal colors instead.

It is impossible to provide a default highlight to fit all color schemes. So, can you tell me the repo of the color scheme you use and the screenshot of the two versions? It will help me think more about this question and provider a option to solve this breaking change.

nanozuki commented 2 years ago

After some thinking, Because the new version of tabby is developing, It's better to not provide a breaking update in the current version, I revert it. Welcome the following feedback.

ehrand commented 2 years ago

@nanozuki thank you, now it looks beautiful again :). Colorscheme I'm using is this: https://github.com/sainnhe/gruvbox-material