nansencenter / DAPPER

Data Assimilation with Python: a Package for Experimental Research
https://nansencenter.github.io/DAPPER
MIT License
348 stars 122 forks source link

Figure numbers #43

Closed patnr closed 3 years ago

patnr commented 3 years ago

For liveplotting, the figure numbers are assigned when defining the liveplots for the model. See lorenz63/__init__.py.

This is fine. Except there might be conflicting numbers. E.g. with the defaults defined at the bottom of liveplotting.py.

But requesting specific liveplotters via assimilate() then requires remembering these numbers. This is inelegant. It should be done by (fuzzy?) names instead.

yumengch commented 3 years ago

I'd like to work on some existing issues but I think I need some clarifications.

I feel avoiding fignum conflict can be done in the Liveplot modules when it is defined from HMM.liveplotter.

But requesting specific liveplotters via assimilate() then requires remembering these numbers. This is inelegant. It should be done by (fuzzy?) names instead.

However, this point seems to imply that you want to remove the requirement of specifying fignum and assign the liveplots argument in assimilate() with the capability of (fuzzy) name match.

Do I understand it correctly?

patnr commented 3 years ago

Indeed, I should have been more verbose.

Keeping the same persistent figure numbers for the liveplotters has served two functions:

Those two functions should be kept somehow.

Then there are the two issues:

However, this point seems to imply that you want to remove the requirement of specifying fignum and assign the liveplots argument in assimilate() with the capability of (fuzzy) name match.

Yes, that's it.

patnr commented 3 years ago

Closed by #63