search

nansencenter / DAPPER

Data Assimilation with Python: a Package for Experimental Research
https://nansencenter.github.io/DAPPER
MIT License
341 stars 119 forks source link

issue #51 #73

Closed yumengch closed 3 years ago

yumengch commented 3 years ago

Guess setter is not sufficient to ensure positive prec.

I also added a __post_init__ function.

patnr commented 3 years ago

Do you know why the tests failed? I guess it might be a nan failing. In this case, since a __post_init__ becomes necessary, I think we might just drop the dataclass.

yumengch commented 3 years ago

Do you know why the tests failed? I guess it might be a nan failing. In this case, since a __post_init__ becomes necessary, I think we might just drop the dataclass.

Yes. I was overconfident as I thought it is a straightforward change. Also, as I the test_data needs to be adapt due to structure change, if you reopen the pull request, all tests should be able to be passed (as I tested on my local repo).