search

nansencenter / django-geo-spaas-sar-doppler

Django Geo-SPaaS application for SAR Doppler shift processing
GNU General Public License v3.0
3 stars 5 forks source link

Specify a polygon geometry with a Shape file #23

Closed korvinos closed 6 years ago

korvinos commented 6 years ago

Description

A feature introduced in #6 and then improved in #12 allows specifying a domain for data ingesting, processing, etc. Methodology, implemented at the moment allows specifying borders and Spatial reference for the domain. It is a very sustainable approach since satisfying a methodology of creating domains implemented in both gdal and nansat.

However, in some cases, it would be beneficial to introduce a nor rectangular domain with a specific shape (i.e. a shape of land objects).

Thus, it should be implemented in the injestor.

Solution

Since it is not very convenient to hardcode a shape in command line while ingesting it can be provided in .shp file or another format such as GeoJSON. It is important, that:

  1. The new feature should complement the more primitive but simple and stable method implemented earlier but not cancel it.
  2. The shape will have a higher priority than a "domain" (i.e. if both were provided, the shape would be used)

TODO

mortenwh commented 6 years ago

Wouldn't this be good to have in Django-Geo-SpaaS? Seems like a general feature that could be useful in other settings a well. We could move it later, though...

Den søn. 29. jul. 2018, 11:32 skrev Artem Moiseev <notifications@github.com

:

Description

A feature introduced in #6 https://github.com/nansencenter/django-geo-spaas-sar-doppler/issues/6 and then improved in #12 https://github.com/nansencenter/django-geo-spaas-sar-doppler/issues/12 allows specifying a domain for data ingesting, processing, etc. Methodology, implemented at the moment allows specifying borders and Spatial reference for the domain. It is a very sustainable approach since satisfying a methodology of creating domains implemented in both gdal and nansat.

However, in some cases, it would be beneficial to introduce a nor rectangular domain with a specific shape (i.e. a shape of land objects).

Thus, it should be implemented in the injestor. Solution

Since it is not very convenient to hardcode a shape in command line while ingesting it can be provided in .shp file or another format such as GeoJSON. It is important, that:

  1. The new feature should complement the more primitive but simple and stable method implemented earlier but not cancel it.
  2. The shape will have a higher priority than a "domain" (i.e. if both were provided, the shape would be used)

TODO

  • Find a suitable for the case file format (Shape, GeoJSON, etc.)
  • Update a BaseCommand as it can take a path to the file and handle reading/validation of the output
  • Update Manager
  • Update tests

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nansencenter/django-geo-spaas-sar-doppler/issues/23, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGqBafszomPHO0S5GU7oipwQeRhCscCks5uLYESgaJpZM4VlWxd .

korvinos commented 6 years ago

Adding it to the geo-spaas is indeed a good idea was also mentioned at the meeting we had about a month ago. But along with that, creating of a generic method should be carefully designed to be used for all (or major) part of applications. Thus in view of the upcoming sprint, you can move it to the geo-spaas later with probably some changes.

korvinos commented 6 years ago

Maybe @akorosov could also comment on this?

korvinos commented 6 years ago

I have done a quick research around and found that GeoJSON could be the best option for providing a domain/geometry specification.

Advantages:

Disadvantages:

korvinos commented 6 years ago

Solved in https://github.com/nansencenter/django-geo-spaas/pull/29