search

nansencenter / sentinel1denoised

Thermal noise subtraction, scalloping correction, angular correction
GNU General Public License v3.0
42 stars 14 forks source link

Updates to download_aux_calibration #83

Closed bhjolly closed 3 years ago

bhjolly commented 3 years ago

Updated code for downloading aux files to match new URL pattern after AUX server shifted to https://qc.sentinel1.groupcls.com

Also added a check of the 'requests' response status code to see if file actually downloaded (if URL resulted in a 404 not found then something was still silently downloaded but the untarring stage would fail as it wasn't a valid gzip file - this lead to a confusing error message later on)

Also added a 'space' to the end of /usr/bin/env python in s1_correction.py as the existing version immediately temrinated with a carriage-return which bash (Linux) didn't appreciate.

akorosov commented 3 years ago

Great work, @bhjolly ! I new about one bug but couldn't find time to fix it. But another one is very well spotted :) Can you please request my review when you are done? Thanks a lot!