search

nanshe-org / nanshe

An image processing toolkit
https://nanshe-org.github.io/nanshe
BSD 3-Clause "New" or "Revised" License
6 stars 6 forks source link

Drop the Matplotlib-based viewer #480

Closed jakirkham closed 5 years ago

jakirkham commented 5 years ago

Drops the old, deprecated code for the Matplotlib-based viewer. This is merely an alias to mplview left in to aid people migrating to mplview, which is better documented, tested, and cleaned up after the refactor. The workflow itself already requires mplview and uses that directly. Also more than a sufficient amount of time has passed since the deprecation. Hence this goes ahead and drops that code and the associated requirements. Users should be able to easily get mplview themselves should they need it.

jakirkham commented 5 years ago

Appears matplotlib is still being installed. Likely because scikit-image requires it.

jakirkham commented 5 years ago

There's also a bit of code in the nanshe/nanshe Docker image, which will need to be shifted to wherever matplotlib does get installed. For now it sounds like it is ok to keep in nanshe/nanshe, but it is something to keep an eye on.

https://github.com/nanshe-org/docker_nanshe/blob/809049be67fcc272e2f5406c914169b1cdd741b0/Dockerfile#L13-L16